Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom download url not use cache #98

Open
PittyXu opened this issue Aug 16, 2024 · 3 comments
Open

Custom download url not use cache #98

PittyXu opened this issue Aug 16, 2024 · 3 comments

Comments

@PittyXu
Copy link

PittyXu commented Aug 16, 2024

Download bun is slowly, I use the custom url like this.

with:
  bun-download-url: "https://**/caches/bun/v1.1.24/bun-linux-x64.zip"
  bun-version: 1.1.24

But it always download from web not from cache.
Expect if cache hit the version, it can use cache, or form local toolcache dir like this.

const tc = require('@actions/tool-cache');

const cachedPath = await tc.cacheDir(extractedFolder, 'bun', '1.1.24');

const bunDirectory = tc.find('bun', '1.1.24', 'x64');
@xhyrom
Copy link
Collaborator

xhyrom commented Aug 16, 2024

We can't ensure that the binary from custom url is always same. Also why you're using custom download url?

@PittyXu
Copy link
Author

PittyXu commented Aug 20, 2024

We can't ensure that the binary from custom url is always same. Also why you're using custom download url?

Downloading is unstable in China

@PittyXu
Copy link
Author

PittyXu commented Aug 20, 2024

I think ensure the binary same should be left up to the user, user specified the custom download and version is that he expects to be able to control the binary.

If a problem occurs, users can correct it themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants