Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global/workspace Lua.workspace.library is merged with folder settings #23

Open
Kaktus2225 opened this issue May 19, 2023 · 6 comments
Open

Comments

@Kaktus2225
Copy link

When I set a path in Lua.workspace.library in workspace settings, it is copied by the extension (after restart) to user settings and only one of the natives is added (instead of three).

@Kaktus2225
Copy link
Author

Now it works when there is a .code-workspace file, but when there is only settings.json is the same issue.

@thelindat
Copy link
Member

https://code.visualstudio.com/api/references/vscode-api#WorkspaceConfiguration

Represents the configuration. It is a merged view of
Default Settings
Global (User) Settings
Workspace settings
Workspace Folder settings - From one of the Workspace Folders under which requested resource belongs to.
Language settings - Settings defined under requested language.

So I can only get a merged config object, but I can save to either global, workspace, or workspace folder.
There's no way for me to check where the setting came from, and I cannot splice or push to an array of settings directly - only modify and update the merged object.

I have no clue how I'm supposed to resolve this.

@thelindat thelindat reopened this May 20, 2023
@thelindat thelindat changed the title Adding paths to Lua.workspace.library do not work properly Global/workspace Lua.workspace.library is merged with folder settings May 20, 2023
@D4isDAVID
Copy link
Contributor

I have no clue how I'm supposed to resolve this.

You should consider getting added to LuaLS/LLS-Addons.

@thelindat
Copy link
Member

I have no clue how I'm supposed to resolve this.

You should consider getting added to LuaLS/LLS-Addons.

Doesn't really solve anything and is less visible to users.

@D4isDAVID
Copy link
Contributor

D4isDAVID commented Jul 8, 2023

Doesn't really solve anything and is less visible to users.

It would solve you having to mess with user settings in weird ways, since iirc addons don't write to the user's settings files Not accurate I guess.

@thelindat
Copy link
Member

It would solve you having to mess with user settings in weird ways, since iirc addons don't write to the user's settings files Not accurate I guess.

Somehow only just saw this response but yeah it will still update user/workspace/folder settings.

I'm still, for some reason, holding out hope that Cfx do their own extension or LLS addon even though the issue is dead; so doing the addon myself would feel a bit awkward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants