From 75a64fa1b1a4b829e71ea85ed8ed5a9fb57a8b48 Mon Sep 17 00:00:00 2001 From: Danyal Faheem <138459282+Danyal-Faheem@users.noreply.github.com> Date: Fri, 8 Dec 2023 14:54:49 +0500 Subject: [PATCH] feat: allow post npm build patch in Dockerfile Close #167 --- .../20231208_112435_danyal.faheem_mfe_post_npm_build_patch.md | 1 + tutormfe/templates/mfe/build/mfe/Dockerfile | 2 ++ 2 files changed, 3 insertions(+) create mode 100644 changelog.d/20231208_112435_danyal.faheem_mfe_post_npm_build_patch.md diff --git a/changelog.d/20231208_112435_danyal.faheem_mfe_post_npm_build_patch.md b/changelog.d/20231208_112435_danyal.faheem_mfe_post_npm_build_patch.md new file mode 100644 index 00000000..8d5bf3cb --- /dev/null +++ b/changelog.d/20231208_112435_danyal.faheem_mfe_post_npm_build_patch.md @@ -0,0 +1 @@ +- [Feature] Added patch to allow changes to Dockerfile after the npm build has completed. (by @Danyal-Faheem) \ No newline at end of file diff --git a/tutormfe/templates/mfe/build/mfe/Dockerfile b/tutormfe/templates/mfe/build/mfe/Dockerfile index f0d74c26..2a55fb0a 100644 --- a/tutormfe/templates/mfe/build/mfe/Dockerfile +++ b/tutormfe/templates/mfe/build/mfe/Dockerfile @@ -93,6 +93,8 @@ CMD ["/bin/bash", "-c", "npm run start --- --config ./webpack.dev-tutor.config.j FROM {{ app_name }}-common AS {{ app_name }}-prod ENV NODE_ENV=production RUN npm run build +{{ patch("mfe-dockerfile-post-npm-build") }} +{{ patch("mfe-dockerfile-post-npm-build-{}".format(app_name)) }} {% endfor %} ####### final production image with all static assets