diff --git a/changelog.d/20231206_183103_arbrandes_fix_trailing_slash.md b/changelog.d/20231206_183103_arbrandes_fix_trailing_slash.md new file mode 100644 index 00000000..5241d67f --- /dev/null +++ b/changelog.d/20231206_183103_arbrandes_fix_trailing_slash.md @@ -0,0 +1 @@ +- [Bugfix] Append trailing slash to PUBLIC_PATH, as its absence breaks some MFEs. (by @arbrandes) diff --git a/tutormfe/templates/mfe/build/mfe/Dockerfile b/tutormfe/templates/mfe/build/mfe/Dockerfile index e2f9ab5e..856b7a31 100644 --- a/tutormfe/templates/mfe/build/mfe/Dockerfile +++ b/tutormfe/templates/mfe/build/mfe/Dockerfile @@ -79,7 +79,7 @@ EXPOSE {{ app['port'] }} # Configuration needed at build time ENV APP_ID={{ app_name }} -ENV PUBLIC_PATH='/{{ app_name }}' +ENV PUBLIC_PATH='/{{ app_name }}/' # We could in theory point the mfe_config API directly to the LMS. But for that we would # have to code the LMS url into the mfe image, and this configuration is user-dependent. # So we point to a relative url that will be a proxy for the LMS.