Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Python images instead of ubuntu in Tutor dockerfiles #1094

Closed
2 of 6 tasks
DawoudSheraz opened this issue Jul 9, 2024 · 5 comments
Closed
2 of 6 tasks
Assignees

Comments

@DawoudSheraz
Copy link
Contributor

DawoudSheraz commented Jul 9, 2024

#1004 focused on updating Python to 3.11/3.12 in respective plugins. Most of the plugins followed the existing pyenv approach for updating Python. It was discussed internally and on some PRs (overhangio/tutor-discovery#67 (comment)) to start instead using python-bookworm-slim images for setting up Python in Dockerfiles. This would remove Python's manual installation and configuration in dockerfile and make the build a bit better.

Tutor Dockerfile Upgrade Status

@arbrandes
Copy link

I brought this to an Axim meeting, and we feel like it would be ideal if we could coordinate this move via the Maintenance WG. We're concerned that a part of the community will be developing and testing on Ubuntu, while Sumac will actually be running on Debian for Tutor users. Would it be possible for @DawoudSheraz or @regisb to join the next Maintenance WG meeting, next Thursday?

@regisb
Copy link
Contributor

regisb commented Aug 9, 2024

Sure, I'll be able to join. So far, my position has been that changing the base image is a major move with important implications that may not have a lot of benefits. I do agree that the installation of python via pyenv is clunky, but we can fix that without changing the base image. For instance, we could use deadsnakes' PPA: https://launchpad.net/~deadsnakes/+archive/ubuntu/ppa (StackOverflow)

@arbrandes I'm not sure I understand your position. I think that you agree that Tutor should remain on Ubuntu, right?

@DawoudSheraz
Copy link
Contributor Author

Closing this as this work is not needed. We will be updating base os to Ubuntu 24.04 #1113 which conflicts with the work intended in this issue.

@DawoudSheraz DawoudSheraz closed this as not planned Won't fix, can't repro, duplicate, stale Aug 20, 2024
@arbrandes
Copy link

@regisb, I think we're on the same page. We (Axim) have no objections in principle to moving to the up Python/debian image as there might be some maintenance advantages, but if we don't coordinate with the community, there might be drawbacks that are too costly.

It seems you're sticking with Ubuntu at least for Sumac, which is fine for us. We can of course continue the conversation going forward.

@DawoudSheraz
Copy link
Contributor Author

One big reason for sticking with Ubuntu (and the 24.04 upgrade) is to make sure Tutor has the same config that the upstream expects. In case some issues arise in the future, it can become difficult to understand if they are in tutor or upstream due to differences in base images. We can look for other ways to ease up on certain maintenance burdens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Won't fix
Development

No branches or pull requests

4 participants