Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/diff endpoint reports no diff in redorderd lists #89

Open
rosibaj opened this issue May 8, 2020 · 0 comments
Open

/diff endpoint reports no diff in redorderd lists #89

rosibaj opened this issue May 8, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@rosibaj
Copy link
Contributor

rosibaj commented May 8, 2020

Description

When comparing two dictionaries with the /diff endpoint, if a list is reordered it reports an empty diff object for that field

Expected Behaviour

This should not be reported as a difference, as the data hasn't actually changed.

Actual Behaviour

image

Possible Fix

Steps to Reproduce

  1. Go to argo-qa environment and compare the two RC candiate dictionaryed 0.10 and 0.11
curl --location --request GET 'https://lectern.qa.argo.cancercollaboratory.org/diff?name=ICGC-ARGO%20Data%20Dictionary%20RC%200.10&left=0.10&right=0.11'
  1. Look at the "donor.menopause_status", diff object
  2. see the empty diff objcet:
 "diff": {}
@rosibaj rosibaj added the bug Something isn't working label May 8, 2020
@joneubank joneubank added the good first issue Good for newcomers label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants