Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Trailing '/' to DMS UI Path Goes to Login Page #100

Open
b-f-chan opened this issue Mar 24, 2021 · 2 comments
Open

Removing Trailing '/' to DMS UI Path Goes to Login Page #100

b-f-chan opened this issue Mar 24, 2021 · 2 comments
Assignees
Labels
bug Something isn't working canarie

Comments

@b-f-chan
Copy link

When entering the URL to the DMS-UI, adding or removing a trailing slash '/' to the path changes the landing page.

E.g.

https://dms.brandon.cancercollaboratory.org/dms-ui --> Goes to the Login page
https://dms.brandon.cancercollaboratory.org/dms-ui/ --> Goes to the Data Explorer page

This creates an inconsistent experience. The landing page should always be the Data Explorer page.

@b-f-chan b-f-chan added bug Something isn't working canarie labels Mar 24, 2021
@b-f-chan b-f-chan modified the milestone: Canarie Sprint 17 Mar 25, 2021
@ciaranschutte
Copy link
Contributor

@b-f-chan having some trouble recreating this locally. Could you check if this is still an issue please?

@b-f-chan
Copy link
Author

b-f-chan commented Mar 8, 2022

After discussing with @ciaranschutte:

  • This is not reproducible on localhost
  • For deployments in server-mode, /dms-ui actually leads to an error page, much like Arranger (/arranger-ui)
  • However, /dms-ui/ leads to the correct Explorer page, much like Arranger projects page (/arranger-ui/)
  • This is very low priority, because in server mode, people will usually use the registered domain name anyways to get to the portal (e.g. portal.eucancan.org), so it would be very rare and unlikely they would use the /dms-ui or /dms-ui/ sub-path
  • Let's park this and fix later, as we have higher priorities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working canarie
Projects
None yet
Development

No branches or pull requests

2 participants