[ProgressBarObserver] progress.json shows "message": "Render starting..." after render is complete

[mtoensing]

I tested this with many different servers with this in my config.py:

# Import the Observers
from observer import MultiplexingObserver, ProgressBarObserver, JSObserver

# Construct the ProgressBarObserver
ProgressBarObserver = ProgressBarObserver()

# Construct a basic JSObserver
jsObserver = JSObserver(outputdir, 30)

# Set the observer to a MultiplexingObserver
observer = MultiplexingObserver(ProgressBarObserver, jsObserver)

progress.json contains "Render starting.." every time the render task is complete. The result: This is then in the leaflet app at the bottom right corner.

[CounterPillow]

Works for me, shows "Render completed in" and then the time it took to render.

Also, don't shadow ProgressBarObserver by assigning it an instance of itself. That's wrong in so many ways.

[mtoensing]

Also, don't shadow ProgressBarObserver by assigning it an instance of itself. That's wrong in so many ways.

Ok, maybe this is the cause for that problem? How do I do it right?

[CounterPillow]

Don't call the variable you're assigning it to ProgressBarObserver but something else, e.g. pbo = ProgressBarObserver()

[mtoensing]

@CounterPillow I figured it out:

This does not work and results in an unfinished state of progress.json
/tmp/overviewer/overviewer.py --config=/tmp/config/config.py && /tmp/overviewer/overviewer.py --config=/tmp/config/config.py --skip-scan --genpoi

This works:
/tmp/overviewer/overviewer.py --config=/tmp/config/config.py --skip-scan --genpoi && /tmp/overviewer/overviewer.py --config=/tmp/config/config.py"]

[Dravere]

So I ran into the problem with "Render starting..." being displayed as well. It seems also to have already been reported back in issue #931.

The problem is that the config.py is compiled and executed every time when Overviewer runs. This will construct the JSObserver object. And in the constructor it overwrites the progress.json.

Minecraft-Overviewer/overviewer_core/observer.py

Line 269 in 3498641

self.logfile.write(json.dumps(self.json).encode())

Thus running genpoi will load the configuration, compile and execute it, and then overwriting the progress.json that was written by the map rendering before. For now I just switched the order for genpoi and map rendering.