Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: implement column filters in Select() #289

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dcbw
Copy link
Contributor

@dcbw dcbw commented Jan 28, 2022

Since the unit test for Monitor() requests all columns,
we now have to expect empty fields for those columns in
the response.

Previously Select() just ignored the columns that
Monitor() requested and thus elided empty columns from
the result.

@trozet @dave-tucker @jcaamano

@jcaamano
Copy link
Collaborator

Just a heads up on the different behavior of including empty columns whether they were requested or not. If no columns were requested, empty columns are not included. For requested columns, empty columns are included.

The RFC is not really explicit about it

   If "columns" is not specified, all the
   table's columns are included (including the internally generated
   "_uuid" and "_version" columns). 

Should we check what the ovs ovsdb server does?

Since the unit test for Monitor() requests all columns,
we now have to expect empty fields for those columns in
the response.

Previously Select() just ignored the columns that
Monitor() requested and thus elided empty columns from
the result.

Signed-off-by: Dan Williams <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1773018781

  • 22 of 32 (68.75%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 73.399%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/transact.go 2 3 66.67%
server/server.go 4 6 66.67%
ovsdb/set.go 1 4 25.0%
mapper/mapper.go 15 19 78.95%
Files with Coverage Reduction New Missed Lines %
server/transact.go 2 69.57%
Totals Coverage Status
Change from base Build 1754146115: -0.03%
Covered Lines: 4423
Relevant Lines: 6026

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants