Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up libovsdbops & tests once referential integrity support is added to the test server #4089

Closed
jcaamano opened this issue Jan 12, 2024 · 2 comments
Assignees
Labels
lifecycle/stale All issues (> 60 days) and PRs (>90 days) with no activity.

Comments

@jcaamano
Copy link
Contributor

Many of our libovsdb ops delete rows that would otherwise be garbage collected by the real OVSDB server.

One of the main reasons we do that is because our test server does not have support for garbage collection. So our code either does delete ops that wouldn't be strictly necessary, which requires for us to be extra careful to not incur in referential integrity violations that could happen if we deleted rows that are still referenced from other places; or if we don't do those delete ops, to account for the leftover rows in the tests potentially hiding other issues.

There is ongoing effort to add referential integrity support in the test server: ovn-org/libovsdb#375

When that is done, we need to:

  • bump libovsdb, fixing our tests of referential integrity violations and cleaning up all leftovers that will now be garbage collected
  • go through our delete ops and remove those that are covered by garbage collection
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the lifecycle/stale All issues (> 60 days) and PRs (>90 days) with no activity. label May 31, 2024
@tssurya
Copy link
Contributor

tssurya commented Jun 3, 2024

#4079 fixed this, closing this

@tssurya tssurya closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale All issues (> 60 days) and PRs (>90 days) with no activity.
Projects
None yet
Development

No branches or pull requests

2 participants