Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libovsdb] Run libovsdb modelgen on latest OVN NB schema #2373

Merged

Conversation

alexanderConstantinescu
Copy link
Collaborator

This commit bumps libovsdb's model to a more recent OVN NB DB schema version which contains elements such as LogicalRouterPolicy.Nexthops and such.

/assign @jcaamano

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

@alexanderConstantinescu alexanderConstantinescu changed the title Run libovsdb modelgen on latest OVN NB schema [libovsdb] Run libovsdb modelgen on latest OVN NB schema Jul 28, 2021
@jcaamano
Copy link
Contributor

jcaamano commented Jul 29, 2021

/lgtm

@dave-tucker wan't there a fix for modelgen that didn't generate arrays for min:0 max:1 properties?

@dave-tucker
Copy link
Collaborator

@jcaamano yes but it's still waiting review ovn-org/libovsdb#204

@jcaamano
Copy link
Contributor

I will give it a shot but I guess @amorenoz needs to look at it as well.

/lgtm

@alexanderConstantinescu
Copy link
Collaborator Author

/retest

Signed-off-by: Alexander Constantinescu <[email protected]>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 53.252% when pulling a54665f on alexanderConstantinescu:bump-modelgen into 676cf92 on ovn-org:master.

@alexanderConstantinescu
Copy link
Collaborator Author

alexanderConstantinescu commented Jul 29, 2021

External GW e2e tests seem to be one fire:

https://github.com/ovn-org/ovn-kubernetes/pull/2373/checks?check_run_id=3193448320



Summarizing 3 Failures:

[Fail] BFD e2e non-vxlan external gateway through a gateway pod Should validate TCP/UDP connectivity to an external gateway's loopback address via a pod with external gateway annotations enabled [It] TCP ipv6 
/home/runner/work/ovn-kubernetes/ovn-kubernetes/test/e2e/external_gateways.go:982

[Fail] BFD e2e multiple external gateway validation Should validate TCP/UDP connectivity to multiple external gateways for a UDP / TCP scenario [It] IPV6 udp 
/home/runner/work/ovn-kubernetes/ovn-kubernetes/test/e2e/external_gateways.go:788

[Fail] BFD e2e multiple external gateway validation Should validate TCP/UDP connectivity to multiple external gateways for a UDP / TCP scenario [It] IPV6 udp 
/home/runner/work/ovn-kubernetes/ovn-kubernetes/test/e2e/external_gateways.go:788

https://github.com/ovn-org/ovn-kubernetes/pull/2373/checks?check_run_id=3193448419

Summarizing 2 Failures:

[Fail] BFD e2e non-vxlan external gateway through a gateway pod Should validate TCP/UDP connectivity to an external gateway's loopback address via a pod with external gateway annotations enabled [It] UDP ipv6 
/home/runner/work/ovn-kubernetes/ovn-kubernetes/test/e2e/external_gateways.go:572

[Fail] BFD e2e non-vxlan external gateway through a gateway pod Should validate TCP/UDP connectivity to an external gateway's loopback address via a pod with external gateway annotations enabled [It] UDP ipv6 
/home/runner/work/ovn-kubernetes/ovn-kubernetes/test/e2e/external_gateways.go:572

No relation to this though, so I am merging

@alexanderConstantinescu alexanderConstantinescu merged commit bf33331 into ovn-org:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants