Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lingering nb/sb ctl calls from the code base #2697

Merged
merged 7 commits into from
Dec 15, 2021
Merged

Remove lingering nb/sb ctl calls from the code base #2697

merged 7 commits into from
Dec 15, 2021

Commits on Dec 15, 2021

  1. Convert OVN Meter + Meter_Band ops to libovsdb 

    Convert the creation/ configuration of the OVN
meter and meter_band objects for the acl-logging
feature to libovdb

Signed-off-by: astoycos <[email protected]>
    astoycos committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    9e12506 View commit details
    Browse the repository at this point in the history

  2. set NB_Global options with libovsdb 

    Set the `controller_event` option on the
nb_global table to `true` with libovsdb

Signed-off-by: astoycos <[email protected]>
    astoycos committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    95729a6 View commit details
    Browse the repository at this point in the history

  3. Remove final nbctl calls from HO code 

    Convert all remaining nbctl calls from the
hybridOverlay package

Update unit test accordingly

Signed-off-by: astoycos <[email protected]>
    astoycos committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    d47a3fc View commit details
    Browse the repository at this point in the history

  4. Remove final sbctl calls from Hybrid Overlay 

    Remove the final sbctl calls regarding mac_bindings
from the hybrid overlay code and convert to libovsdb

Ensure we index mac_binding by both possible options,
the `logical_port` OR `ip` columns

Signed-off-by: astoycos <[email protected]>
    astoycos committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    1b94cbb View commit details
    Browse the repository at this point in the history

  5. Cleanup OVN package 

    Remove some erronous fexec calls

Remove the NBtxn struct and associated
helper functions

Signed-off-by: astoycos <[email protected]>
    astoycos committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    c3472e1 View commit details
    Browse the repository at this point in the history

  6. Remove some nb/sb ctl helper functions 

    Remove all of the unused nb/sb ctl helper functions
from the util package and add notes on when
the rest can be removed

Signed-off-by: astoycos <[email protected]>
    astoycos committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    c8c1899 View commit details
    Browse the repository at this point in the history

  7. Move libovsdbops package 

    Move the libovsdbops package out of the
`go-controller/pkg/ovn` directory and into
`go-controller/pkg` since its used by many packages
in the directory.

Signed-off-by: astoycos <[email protected]>
    astoycos committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    cd445c5 View commit details
    Browse the repository at this point in the history