Metrics: Start OVN DB/Northd metrics only on OVNKube master #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this change, if you enabled OVN metrics endpoint on OVNKube master and OVNKube node you get duplicate metrics for OVN DB/Northd. If you enable just OVNKube node only, you must have access to the OVN DB/Northd. With this PR, a single OVNKube master leader will export OVN DB/Northd metrics and OVNKube node can solely focus on OVN controller metrics. Signed-off-by: Martin Kennelly <[email protected]>
|
@astoycos Can you take a look at this? |
astoycos
reviewed
Dec 15, 2021
| // Note: for ovnkube node mode dpu-host no ovn metrics is required as ovn is not running on the node. | ||
| if config.OvnKubeNode.Mode != types.NodeModeDPUHost && config.Kubernetes.OVNMetricsBindAddress != "" { | ||
| metrics.RegisterOvnMetrics(ovnClientset.KubeClient, node) | ||
| if master != "" { |
There was a problem hiding this comment.
Right... I made this issue -> #2713 to track this
Short of it is @girishmg doesn't run the ovn-dbs necessarily on the same nodes as the ovnkub-master like described here #2697 (comment) so we can't only export metrics on the ovnkube-master nodes if I'm understanding correctly
There was a problem hiding this comment.
I see. This PR doesn't make sense so. Thanks Andrew.
|
Closing this because I didn't consider other community deployment scenarios where OVNKube master is not co-located with OVN dbs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this change, if you enabled OVN metrics
endpoint on OVNKube master and OVNKube node you get
duplicate metrics for OVN DB/Northd.
If you enable just OVNKube node only, you must
have access to the OVN DB/Northd.
With this PR, a single OVNKube master leader will
export OVN DB/Northd metrics and OVNKube node can
solely focus on OVN controller metrics.
Signed-off-by: Martin Kennelly [email protected]
@girishmg Can you take a look at this? I believe you were working on this originally.