Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fedora: Update Dockerfile to OVN release ovn-24.09.0-33. #4730

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fedora: Update Dockerfile to OVN release ovn-24.09.0-33. #4730

merged 1 commit into from
Sep 18, 2024

Conversation

numansiddique
Copy link
Contributor

What this PR does and why is it needed

Which issue(s) this PR fixes

Fixes #

Special notes for reviewers

How to verify it

Details to documentation updates

Description for the changelog

Does this PR introduce a user-facing change?

@numansiddique numansiddique requested a review from a team as a code owner September 17, 2024 20:40
@numansiddique numansiddique mentioned this pull request Sep 17, 2024
Merged
dceara
dceara approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@dceara dceara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

tssurya
tssurya reviewed Sep 18, 2024
View reviewed changes
dist/images/Dockerfile.fedora
@@ -15,7 +15,7 @@ USER root

ENV PYTHONDONTWRITEBYTECODE yes

ARG ovnver=ovn-24.03.90-7.fc41
ARG ovnver=ovn-24.09.0-33.fc41
Copy link
Contributor

@tssurya tssurya Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are major commit differences between these as far as ovnk is concerned? the 90-7 prereleased one is exactly same as 0-33 ?
asking to see if on our side we need to add any tests for known bug fixes we might bringing in...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT they're identical, the only new thing that happened was bumping the release number and tagging it. No functional differences.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack thanks!

@tssurya
Copy link
Contributor

tssurya commented Sep 18, 2024

I see https://github.com/ovn-org/ovn-kubernetes/actions/runs/10910768637/job/30283028236?pr=4730 lane failing, I will retrigger to be sure its not related to this change.

tssurya
tssurya approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@tssurya tssurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge after CI run

@dceara
Copy link
Contributor

dceara commented Sep 18, 2024

I see https://github.com/ovn-org/ovn-kubernetes/actions/runs/10910768637/job/30283028236?pr=4730 lane failing, I will retrigger to be sure its not related to this change.

Isn't this related (the same?) as #4670?

@tssurya tssurya merged commit a6ae180 into ovn-kubernetes:master Sep 18, 2024
39 checks passed
@numansiddique numansiddique deleted the ovn24.09_release branch September 19, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dceara dceara dceara approved these changes

@tssurya tssurya tssurya approved these changes

@ricky-rav ricky-rav Awaiting requested review from ricky-rav ricky-rav was automatically assigned from ovn-org/ovn-kubernetes-members

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@numansiddique @tssurya @dceara