Services NodePort E2Es: Reset shared variables before each test #4740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/e2e-testing
feature/services&endpoints
kyrtapz
force-pushed
the
nodeips_svc_e2e_fix
branch
from
5fe8ad0
to
1d2814e
Compare
dceara
reviewed
Sep 19, 2024
|
The commit log probably needs a |
|
Also, @tssurya can we please also cherry pick this to the |
Fixes: ovn-kubernetes#4733 Signed-off-by: Patryk Diak <[email protected]>
kyrtapz
changed the title
kyrtapz
force-pushed
the
nodeips_svc_e2e_fix
branch
from
1d2814e
to
d6f145e
Compare
dceara
approved these changes
Sep 19, 2024
jcaamano
approved these changes
Sep 19, 2024
|
@kyrtapz can you please open a backport to release-1.0 as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset shared variables before each test to avoid cleanup issues.
Fixes: #4733.