Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rally Dockerfile does not take effect from committed change #54

Open
huikang opened this issue Jun 23, 2016 · 3 comments
Open

rally Dockerfile does not take effect from committed change #54

huikang opened this issue Jun 23, 2016 · 3 comments

Comments

@huikang
Copy link
Collaborator

huikang commented Jun 23, 2016

Problem description: if a commit change anything in rally-ovs, the rally Dockerfile can not receive the new update. This is because rally Dockerfile clones the repo form upstream.

Then a following PR is needed to fix this issue, e.g., #53 .

One possible solution is to generate Dockerfile dynamically, using jinja2 tempate.

@mestery
Copy link
Collaborator

mestery commented Jun 24, 2016

@huikang Is this still relevant now that #53 has merged?

@huikang
Copy link
Collaborator Author

huikang commented Jun 24, 2016

@mestery Yes, this is because rally Dockerfile contains the link to this ovn-scale-test repo. We should fix this later.
But, lets keep this as an open issue so it will not get lost. Thanks.

@huikang
Copy link
Collaborator Author

huikang commented Jul 22, 2016

Lets keep this issue open for some time to ensure it works for everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants