Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anvil Nether renders only show the roof (and things built up there) #25

Open
rjp opened this issue May 20, 2021 · 1 comment
Open

Anvil Nether renders only show the roof (and things built up there) #25

rjp opened this issue May 20, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@rjp
Copy link
Contributor

rjp commented May 20, 2021

I had a bash at trying to fix this by adding a --clip argument that restricts the "what's the highest block at this coord?" but, alas, my Rust is suboptimal and it doesn't really work properly when you have things built on the roof.

Overviewer handles it by, afaict, removing everything attached to the roof (y=128) which would be a good start, I guess (but that also fails for people who have built on the roof.)

Maybe "for dimension==nether, only load blocks y<=128 then remove anything attached to y=128"? Happy to have a look at doing this...

Nether with no clipping:
unclipped

Nether with --clip 110 (to mimic roof removal):
clipped-110

@owengage
Copy link
Owner

Hey there. Yep the current implementation leaves a lot to be desired hah.

At one point or another I've experimented with exactly the kind of stuff you have here. I feel like it might be the sort of thing that can have different approaches via some option.

I'm going to keep this open,and I might have a bash at it at some point.

@owengage owengage added the enhancement New feature or request label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants