Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomWidget is always modified or replaced? #103

Open
wavewave opened this issue Aug 26, 2021 · 2 comments
Open

CustomWidget is always modified or replaced? #103

wavewave opened this issue Aug 26, 2021 · 2 comments

Comments

@wavewave
Copy link

From this code bit

patch (SomeState (stateTree :: StateTree st w e c cs)) old new =

CustomKeep case is never mapped to Keep in Patch, therefore it induces lots of unnecessary UI updates.
I noticed this from my work. Is there any reason that it was implemented in that way? Thanks.

@owickstrom
Copy link
Owner

owickstrom commented Aug 28, 2021

Thanks for the report! It does look like an oversight, indeed. Would you be willing to submit a PR and add the missing handling of Keep?

@wavewave
Copy link
Author

wavewave commented Sep 3, 2021

Yes, I will. I haven't tried to patch this yet, but definitely I can try in my current work context. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants