Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove false positives of site-screenshots in CI #3921

Open
rakyi opened this issue Sep 3, 2024 · 0 comments
Open

Remove false positives of site-screenshots in CI #3921

rakyi opened this issue Sep 3, 2024 · 0 comments
Labels
priority 3 - nice to have site

Comments

@rakyi
Copy link
Contributor

rakyi commented Sep 3, 2024 •
edited by danyx23
Loading

The automated buildkite job that currently runs always shows a difference because the URL in the citation block is different between prod and staging servers.

Technical notes

Towards the bottom of most article pages the citation shows a URL that is server specific. We would have to change this to always use the production URL so that there is no spurious visual difference.
@rakyi rakyi mentioned this issue Sep 3, 2024
Closed
@danyx23 danyx23 changed the title Improve site-screenshot tool Remove false positives of site-screenshots in CI Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority 3 - nice to have site
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danyx23 @rakyi