Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sortinfo in DMRS #33

Open
arademaker opened this issue Aug 18, 2021 · 3 comments
Open

sortinfo in DMRS #33

arademaker opened this issue Aug 18, 2021 · 3 comments

Comments

@arademaker
Copy link
Member

arademaker commented Aug 18, 2021

we should not produce a node that doesn't have any info besides its type...

http://wordnet.princeton.edu/pwn30/01000442-a-1#node-10005>
    <http://www.delph-in.net/schema/cfrom> 22 ;
    <http://www.delph-in.net/schema/cto> 25 ;
    <http://www.delph-in.net/schema/dmrs#hasId> 10005 ;
    <http://www.delph-in.net/schema/hasPredicate> <http://wordnet.princeton.edu/pwn30/01000442-a-1#predicate-10005> ;
    <http://www.delph-in.net/schema/hasSortInfo> <http://wordnet.princeton.edu/pwn30/01000442-a-1#sortinfo-10005> ;
    a <http://www.delph-in.net/schema/dmrs#Node> ;
    <http://www.w3.org/2000/01/rdf-schema#label> "_the_q<22,25>" .

...

<http://wordnet.princeton.edu/pwn30/01000442-a-1#sortinfo-10000>
    a <http://www.delph-in.net/schema/SortInfo> .

The quantifiers seem to not carry sortinfo information. See here

@yfaria yfaria mentioned this issue Aug 18, 2021
@yfaria
Copy link
Contributor

yfaria commented Aug 18, 2021

In #34 I addressed the issue, but I just checked #21 and in a comment there is this XML-serialization:

<dmrs cfrom="-1" cto="-1" top="10003" index="10003">
  <node nodeid="10000" cfrom="0" cto="13">
    <gpred>udef_q</gpred>
    <sortinfo />
  </node>
  <node nodeid="10001" cfrom="0" cto="6">
    <realpred lemma="mask" pos="v" sense="1" />
    <sortinfo SF="prop" TENSE="untensed" MOOD="indicative" PROG="bool" PERF="-" cvarsort="e" />
  </node>
...  
 </dmrs>

So the "sortinfo" is still being outputted even though there is no information in it. If we want the RDF serialization to be as close as the XML one, I think we should let the code generate this node.

@arademaker
Copy link
Member Author

Let us see what will be the comments in delph-in/docs#27

@arademaker arademaker changed the title sortinfo sortinfo in DMRS Sep 2, 2021
@arademaker
Copy link
Member Author

arademaker commented Nov 4, 2021

OK, Michael presented some arguments for not changing the XML Schema, but I still believe that RDF needs different decision since it doesn't make sense to have a node without any property besides its type. Moreover. RDF validation and schema are complete different from XML. So this issue is about:

  1. adaptation of the RDF Schema (vocabulary of DMRS)
  2. adaption of the code to produce a sortinfo node only when we do have information to attach to this node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants