Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review test coverage for REPORT method in DAV #634

Closed
phil-davis opened this issue Dec 12, 2019 · 5 comments
Closed

Review test coverage for REPORT method in DAV #634

phil-davis opened this issue Dec 12, 2019 · 5 comments

Comments

@phil-davis
Copy link
Contributor

See owncloud/core#25373 and #297 (comment)

  • see what test we already have
  • make a report of what is covered by tests and what is not
  • improve the coverage
@kiranparajuli589
Copy link

kiranparajuli589 commented Mar 20, 2020

Test coverage for REPORT method:

  1. Search

    • search for entry by pattern(pattern, incomplete pattern, extensions, empty fields, emojis)
    • limit returned entries to desired value
    • search requesting extra properties like file-id, permissions, e-tags, sizes etc for file/folders
  2. Comments

    • get more information of comments on a resource
  3. Favorites

    • check for Favorited elements

@phil-davis
Copy link
Contributor Author

Maybe it is possible to REPORT on:

  • tags (files with a tag, tags on a file, or what tags exist or?)
  • versions (how many versions are stored, the date of each old version?)
  • files/folders in the trashbin (I guess resources in the trashbin get their comments, tags and "favorite" status saved and restored? That is another set of things to test in the trashbin tests - I should make a separate issue)
  • shares (that might have only the sharing API and not a REPORT)

@kiranparajuli589
Copy link

kiranparajuli589 commented Mar 24, 2020

  • tags (files with a tag, tags on a file, or what tags exist or?)

@phil-davis According to oC documentation, possible REPORT method on tagsAPI is
Screenshot from 2020-03-24 15-30-15
From the API we can retrive resources connected with provided tagId, but I think there is no REPORT method to get tag associated for provided resource
Also, For checking existing tags also, we can check easily using PROPFIND but REPORT method seems yet to implemented

@phil-davis
Copy link
Contributor Author

@kiranparajuli589 yes, that is probably correct. Information about the tags on a resource is probably just available with PROPFIND.

So we just make test scenarios that use REPORT to find the resources that have a particular tag (or set of tags). And include test scenarios that find resources across various different folders...

@saw-jan
Copy link
Member

saw-jan commented Jan 22, 2021

@phil-davis If there're no more tests to be added, can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants