Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] 1.4.11 Non-text contrast #11583

Closed
2 of 3 tasks
tschiebel opened this issue Apr 9, 2024 · 9 comments
Closed
2 of 3 tasks

[a11y] 1.4.11 Non-text contrast #11583

tschiebel opened this issue Apr 9, 2024 · 9 comments

Comments

@tschiebel
Copy link

tschiebel commented Apr 9, 2024

https://infinite.owncloud.com/s/KcGPhbRgJfHYHuw

BIT inklusiv BITV-Softwaretest - BIT inklusiv (bit-inklusiv.de)

Space and Settings

  • The active tabs (checkboxes) in the navigation (toolbar) differ from the inactive tabs
    the non-active tabs only by the background color. The
    contrast requirements are not met, as the contrast ratio between active and inactive
    active and non-active tabs is less than 3:1, at only 1.1:1.
    increasing the contrast, emphasizing the labeling with bold print or adding a frame color.
    by using bold print or adding a frame.

Server activity and Synchronization protocol

  • Active tabs such as "Server activity" differ from the inactive tabs
    tabs only by the background color. The
    contrast requirements are not met, as the contrast ratio between active
    active and non-active tabs is less than 3:1, at only 1.4:1.
    solution would be, for example, to increase the contrast, emphasize the
    the labeling with bold print or increasing the contrast of the frame.

  • Active tabs (checkboxes) of the navigation (toolbar) - See comment on
    Space.

@erikjv
Copy link
Collaborator

erikjv commented Jun 5, 2024

About tab contrast:

Screenshot 2024-06-05 at 18 04 12

For me (on mac) the contrast is fine. Which platform is this tested on?

@erikjv
Copy link
Collaborator

erikjv commented Jun 11, 2024

For Windows most contrast issues are fixed by using the "High Contrast" theme.

@TheOneRing
Copy link
Contributor

@erikjv Could you gather a bunch of screenshots with the high contrast theme?

@tbsbdr tbsbdr added this to the Accessibility milestone Aug 1, 2024
@erikjv
Copy link
Collaborator

erikjv commented Aug 16, 2024

With the "Aquatic" contrast theme on windows 11:

Image

Image

@erikjv
Copy link
Collaborator

erikjv commented Aug 16, 2024

With the "Glow" (non-contrast) theme (Win11):

Image

Image

@erikjv
Copy link
Collaborator

erikjv commented Aug 16, 2024

For both: I've set my laptop to use a smaller default font.

@erikjv erikjv assigned erikjv and unassigned erikjv Aug 16, 2024
@TheOneRing
Copy link
Contributor

TheOneRing commented Aug 19, 2024

Could you also test with a build where:

QApplication::setStyle(QStringLiteral("fusion"));
QQuickStyle::setStyle(QStringLiteral("Fusion"));
is commented out?
As those two look pretty similar....

@erikjv
Copy link
Collaborator

erikjv commented Aug 23, 2024

What is still a problem are the tabs in the activity view: the fusion theme (and the new Windows theme) do not show much contrast between active and inactive tabs

@erikjv
Copy link
Collaborator

erikjv commented Aug 23, 2024

Closing this issue, the problem described above now has its own issue: #11825

@erikjv erikjv closed this as completed Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants