Fix crash when multiple share dialogs were shown #11908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
reviewed
Sep 26, 2024
| connect(w, &QObject::destroyed, this, &ownCloudGui::slotRemoveDestroyedShareDialogs); | ||
| qCInfo(lcApplication) << "Opening new share dialog" << sharePath << localPath << maxSharingPermissions; | ||
| if (_shareDialog) { | ||
| _shareDialog->close(); |
There was a problem hiding this comment.
It should also work if we stack them, so should add another one?
There was a problem hiding this comment.
No, just 1 sharing dialog for the latest. If a user requested one before but never used it to copy the link, then 🤷, apparently it wasn't important.
erikjv
force-pushed
the
work/fix-share-dialog-crash
branch
from
f2e2fb1
to
fd0593c
Compare
|
Note: document that this is oC10 only functionality. |
erikjv
force-pushed
the
work/fix-share-dialog-crash
branch
from
fd0593c
to
3cf826d
Compare
TheOneRing
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11673