Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] publicWebDAVAPIVersion not used in acceptance test publicLocksFileLastSharedFolder #40756

Closed
phil-davis opened this issue Apr 25, 2023 · 4 comments
Assignees
Labels

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Apr 25, 2023

In tests/acceptance/features/bootstrap/WebDavLockingContext.php the function publicLocksFileLastSharedFolder takes parameter $publicWebDAVAPIVersion but the parameter is not used anywhere.

Test scenarios that use this code, and think that they are testing both public webDAV API end-points are not actually doing that.

Needs investigation and correction.

After fixing in core, also check if this code is also in the ocis API acceptance tests, and fix it there also.

@SwikritiT SwikritiT changed the title [tests-only] publicWebDAVAPIVersion not ued in acceptance test publicLocksFileLastSharedFolder [tests-only] publicWebDAVAPIVersion not used in acceptance test publicLocksFileLastSharedFolder Apr 26, 2023
@KarunAtreya
Copy link
Contributor

KarunAtreya commented Jul 14, 2023

@phil-davis In tests/acceptance/features/bootstrap/WebDavLockingContext.php the function publicLocksFileLastSharedFolder is not used anywhere on ocis because there is no locking feature in ocis owncloud/ocis#1284
So am i required to fix this issue in core only?

@phil-davis
Copy link
Contributor Author

@KarunAtreya fix it in core, then also apply the same fix in the ocis code.
The code was copied from core to ocis a while ago, to make it easier to manage the test development for ocis. But when there are test code issues/bugs we should apply fixes to both places.

@phil-davis
Copy link
Contributor Author

Test code was fixed in #40883

@phil-davis
Copy link
Contributor Author

A server issue #40882 was found. That needs separate action - see the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants