You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In tests/acceptance/features/bootstrap/WebDavLockingContext.php the function publicLocksFileLastSharedFolder takes parameter $publicWebDAVAPIVersion but the parameter is not used anywhere.
Test scenarios that use this code, and think that they are testing both public webDAV API end-points are not actually doing that.
Needs investigation and correction.
After fixing in core, also check if this code is also in the ocis API acceptance tests, and fix it there also.
The text was updated successfully, but these errors were encountered:
SwikritiT
changed the title
[tests-only] publicWebDAVAPIVersion not ued in acceptance test publicLocksFileLastSharedFolder
[tests-only] publicWebDAVAPIVersion not used in acceptance test publicLocksFileLastSharedFolder
Apr 26, 2023
@phil-davis In tests/acceptance/features/bootstrap/WebDavLockingContext.php the function publicLocksFileLastSharedFolder is not used anywhere on ocis because there is no locking feature in ocis owncloud/ocis#1284
So am i required to fix this issue in core only?
@KarunAtreya fix it in core, then also apply the same fix in the ocis code.
The code was copied from core to ocis a while ago, to make it easier to manage the test development for ocis. But when there are test code issues/bugs we should apply fixes to both places.
In
tests/acceptance/features/bootstrap/WebDavLockingContext.php
the functionpublicLocksFileLastSharedFolder
takes parameter$publicWebDAVAPIVersion
but the parameter is not used anywhere.Test scenarios that use this code, and think that they are testing both public webDAV API end-points are not actually doing that.
Needs investigation and correction.
After fixing in core, also check if this code is also in the ocis API acceptance tests, and fix it there also.
The text was updated successfully, but these errors were encountered: