Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details for the monitoring / metrics section #793

Open
mmattel opened this issue Apr 16, 2024 · 2 comments
Open

Details for the monitoring / metrics section #793

mmattel opened this issue Apr 16, 2024 · 2 comments

Comments

@mmattel
Copy link
Contributor

mmattel commented Apr 16, 2024

References: #695 ([5.0] Add metrics to the proxy service description)

While working on the referenced PR, I identified that we have metrics not only in the proxy but also in other services but only proxy currently has a description. This leads to the point that it is much better to have an own monitoring section and describe all stuff there and reference in the services affected that new monitoring section. This makes such a documentation future proof and readable.

The following services have a metrics implementation:

grep -rn metrics.Metrics

web
thumbnails
webfinger
eventhistory
store
ocs
idp
graph
webdav
settings
search
userlog
invitations
proxy

We also need to add the metrics requirement part of the new service documentation in the dev docs. (done see referenced PR below)

Questions:

  • How does one know which services have a metrics endpoint (except parsing the code)
  • Not all services do have a metrics endpoint which is most likely ok, but do all which should have one?
  • Are the results queried on the endpoint on each service identical to that what we have in proxy or are they differnt?
@mmattel
Copy link
Contributor Author

mmattel commented Apr 16, 2024

Closing, all services where metrics are implemented are gathered via the proxy service.

@mmattel mmattel closed this as completed Apr 16, 2024
@mmattel mmattel reopened this Apr 16, 2024
@mmattel
Copy link
Contributor Author

mmattel commented Apr 16, 2024

Reopening as we have to think about what to do in Standalone Mode (vs single binary).

@mmattel mmattel changed the title Add a monitoring / metrics section Details for the monitoring / metrics section Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Qualification
Development

No branches or pull requests

1 participant