From 10f4af1e59c286445b8b8ab7608e33c2d10b6022 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20Franke?= Date: Wed, 22 Mar 2023 13:13:32 +0100 Subject: [PATCH] Instead of trying to guess names, ignore them. --- .../pkg/backends/keycloak/backend.go | 21 +++---------------- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/services/invitations/pkg/backends/keycloak/backend.go b/services/invitations/pkg/backends/keycloak/backend.go index e097be9c9b3..fa42f2c51d9 100644 --- a/services/invitations/pkg/backends/keycloak/backend.go +++ b/services/invitations/pkg/backends/keycloak/backend.go @@ -5,7 +5,6 @@ import ( "context" "crypto/tls" "fmt" - "strings" "github.com/Nerzal/gocloak/v13" "github.com/google/uuid" @@ -74,17 +73,14 @@ func (b Backend) CreateUser(ctx context.Context, invitation *invitations.Invitat } u := uuid.New() - firstName, lastName := splitDisplayName(invitation.InvitedUserDisplayName) b.logger.Info(). Str(idAttr, u.String()). Str("email", invitation.InvitedUserEmailAddress). Msg("Creating new user") user := gocloak.User{ - FirstName: &firstName, - LastName: &lastName, - Email: &invitation.InvitedUserEmailAddress, - Enabled: gocloak.BoolP(true), - Username: &invitation.InvitedUserEmailAddress, + Email: &invitation.InvitedUserEmailAddress, + Enabled: gocloak.BoolP(true), + Username: &invitation.InvitedUserEmailAddress, Attributes: &map[string][]string{ idAttr: {u.String()}, userTypeAttr: {userTypeVal}, @@ -142,14 +138,3 @@ func (b Backend) getToken(ctx context.Context) (*gocloak.JWT, error) { return token, nil } - -// Quick and dirty way to split the last name off from the first name(s), imperfect, because -// every culture has a different conception of names. -func splitDisplayName(displayName string) (string, string) { - parts := strings.Split(displayName, " ") - if len(parts) <= 1 { - return parts[0], "" - } - - return strings.Join(parts[:len(parts)-1], " "), parts[len(parts)-1] -}