Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] run secure-viewer role tests with @env-config #10075

Open
saw-jan opened this issue Sep 17, 2024 · 0 comments
Open

[QA] run secure-viewer role tests with @env-config #10075

saw-jan opened this issue Sep 17, 2024 · 0 comments
Labels

Comments

@saw-jan
Copy link
Member

saw-jan commented Sep 17, 2024

Currently, we are running secure-viewer tests by enabling secure-viewer role using GRAPH_AVAILABLE_ROLES in the drone config.

ocis/.drone.star

Line 2091 in 1fe133d

"GRAPH_AVAILABLE_ROLES": "b1e2218d-eef8-4d4c-b82d-0f1a1b48f3b5,a8d5fe5e-96e3-418d-825b-534dbdf22b99,fb6c3e19-e378-47e5-b277-9732f9de6e21,58c63c02-1d89-4572-916a-870abc5a1b7d,2d00ce52-1fc2-4dbc-8b95-a73b73395f5a,1c996275-f1c9-4e71-abdf-a42f6495e960,312c0871-5ef7-4b3a-85b6-0e4074c64049,aa97fe03-7980-45ac-9e50-b325749fd7e6",

We have a step to enable the role:
Given the administrator has enabled the permissions role "Space viewer"

So, let's run the other tests with default enabled roles (without setting GRAPH_AVAILABLE_ROLES) and use the above step for secure-viewer role tests.

Todo:

  • remove the use of GRAPH_AVAILABLE_ROLES
  • for secure-viewer tests, use @env-config and step Given the administrator has enabled the permissions role "Secure viewer"
  • rename role name Secure viewer to Secure Viewer (for consistency)
  • split secure-viewer tests from others if needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant