Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to set OCM_OCM_STORAGE_DATA_SERVER_URL in the deployment example #10540

Closed
mmattel opened this issue Nov 11, 2024 · 4 comments
Closed

Comments

@mmattel
Copy link
Contributor

mmattel commented Nov 11, 2024

There have been two PR's:

#10440 (fix(ocm): add data_server_url to ocm storage provider)
#10538 (fix local ocm instance)

The first one introduced OCM_OCM_STORAGE_DATA_SERVER_URL,
the second one uses it in tests.

Q: do we need to set this envvar in the ocis.yaml file in the ocis_full deployment example?

@micbar @rhafer @ScharfViktor

@ScharfViktor
Copy link
Contributor

yes, if we want to have ocm in the ocis_full
I guess it can be added here #10420
@2403905 FYI

@micbar
Copy link
Contributor

micbar commented Nov 11, 2024

We should have ocm in the example yes. But we should only have One ocis. Not two. The debugging setup with two ocis instances on the same host is not for production and therefore not part of ocis-full.

@mmattel
Copy link
Contributor Author

mmattel commented Nov 11, 2024

If we add the envvar, we should create an independent PR and reference it accordingly to the introduction PR of the envvar. Creating the PR is not the problem, I need help for the content (value of the envvar)

@micbar
Copy link
Contributor

micbar commented Nov 11, 2024

The env var is not new.

The edge case from @ScharfViktor was only needed for two ocm services on the same host.

Not needed for ocis-full.

@micbar micbar closed this as completed Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants