From 5c13e7fd8e15642606d754285aa5ca0a0f2a9fbc Mon Sep 17 00:00:00 2001 From: Paul Neubauer Date: Mon, 25 Apr 2022 10:54:03 +0200 Subject: [PATCH 1/7] Make OcBreadcrumb overflow to the left and hide overflown items --- .../OcBreadcrumb/OcBreadcrumb.spec.js | 2 +- .../molecules/OcBreadcrumb/OcBreadcrumb.vue | 166 +++++++++------- .../__snapshots__/OcBreadcrumb.spec.js.snap | 188 +++++++++--------- 3 files changed, 187 insertions(+), 169 deletions(-) diff --git a/src/components/molecules/OcBreadcrumb/OcBreadcrumb.spec.js b/src/components/molecules/OcBreadcrumb/OcBreadcrumb.spec.js index 6d4e78ea4..38d87fb89 100644 --- a/src/components/molecules/OcBreadcrumb/OcBreadcrumb.spec.js +++ b/src/components/molecules/OcBreadcrumb/OcBreadcrumb.spec.js @@ -18,7 +18,7 @@ describe("OcBreadcrumb", () => { }) expect(wrapper.props().variation).toMatch("lead") - expect(wrapper.classes()).toContain("oc-breadcrumb-lead") + expect(wrapper.html()).toContain("oc-breadcrumb oc-breadcrumb-lead") expect(wrapper).toMatchSnapshot() }) it("displays all items", () => { diff --git a/src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue b/src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue index bfaf840ee..81ad5a347 100644 --- a/src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue +++ b/src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue @@ -1,88 +1,90 @@ @@ -172,7 +192,6 @@ export default { overflow: hidden; flex-shrink: 0; width: auto; - right: 0; position: absolute; white-space: nowrap; diff --git a/src/system.js b/src/system.js index c52fcd482..c2297f345 100644 --- a/src/system.js +++ b/src/system.js @@ -4,7 +4,8 @@ * * You should & can add your own dependencies here if needed. */ - +import Vue from 'vue' +import { ObserveVisibility } from 'vue-observe-visibility' import "./styles/styles.scss" import { getSizeClass } from "./utils/sizeClasses.js" @@ -46,6 +47,8 @@ const System = { Object.keys(components).forEach(name => Vue.component(name, components[name])) Object.keys(directives).forEach(name => Vue.directive(name, directives[name])) + + Vue.directive('observe-visibility', ObserveVisibility) }, } diff --git a/yarn.lock b/yarn.lock index 823f5f903..82a362138 100644 --- a/yarn.lock +++ b/yarn.lock @@ -13153,6 +13153,11 @@ vue-loader@^15.9.0: vue-hot-reload-api "^2.3.0" vue-style-loader "^4.1.0" +vue-observe-visibility@^1.0.0: + version "1.0.0" + resolved "https://registry.yarnpkg.com/vue-observe-visibility/-/vue-observe-visibility-1.0.0.tgz#17cf1b2caf74022f0f3c95371468ddf2b9573152" + integrity sha512-s5TFh3s3h3Mhd3jaz3zGzkVHKHnc/0C/gNr30olO99+yw2hl3WBhK3ng3/f9OF+qkW4+l7GkmwfAzDAcY3lCFg== + vue-select@^3.12.0: version "3.18.3" resolved "https://registry.yarnpkg.com/vue-select/-/vue-select-3.18.3.tgz#31f188d7181a4a86d07b937303c457efe863c4bc" From 2fdd2ef1d214ac304e6a7c1b4441731fac2f2797 Mon Sep 17 00:00:00 2001 From: Paul Neubauer Date: Mon, 25 Apr 2022 17:28:17 +0200 Subject: [PATCH 3/7] WIP --- .../molecules/OcBreadcrumb/OcBreadcrumb.vue | 24 ++++++++++++++----- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue b/src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue index e74d9fe66..b7492e1cf 100644 --- a/src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue +++ b/src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue @@ -1,6 +1,6 @@