Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landscape Mode in RMPP #127

Closed
dnakath opened this issue Dec 29, 2024 · 5 comments
Closed

Landscape Mode in RMPP #127

dnakath opened this issue Dec 29, 2024 · 5 comments

Comments

@dnakath
Copy link

dnakath commented Dec 29, 2024

Hi everybody,

thank you very much for the initial support of the RMPP -- I can also confirm that it is working on my side. However, as already mentioned by @alexander-akhmetov , the landscape mode is not working yet. @owulveryck, if that helps as a first hint, I found that setting the rotation matrix in updateTexture() like so

const rotationMatrix = shouldRotate ? makeRotationZMatrix(90) : makeRotationZMatrix(0);

displays a correct image, when calling (using landscape mode and right hand writing on RMPP)

https://10.11.99.1:2001/?portrait=true

still, the laser pointer remains broken (in landscape mode) and also the flip option from @zihaooo behaves strangely.

I hope this helps as a starting point to get this issue fixed -- if I find time, I will also try to dig more into this.

Thank you all for the great work -- once this is running it will be a great help for teaching!

@Andrea79
Copy link

Andrea79 commented Jan 2, 2025

Hi @dnakath for me it works just fine on my RMPP by putting using the portrait and flip parameters as follows:

https://10.11.99.1:2001/?portrait=true&flip=true

It is true though that the laser pointer is broken in portrait mode.

I am on the latest version of the softwate (v0.19-beta2) and on the latest firmware of RMPP (3.16.2.3)

What do you mean by the flip option behaves strangely?

@dnakath dnakath changed the title Landscape Mode in RMP Landscape Mode in RMPP Jan 3, 2025
@dnakath
Copy link
Author

dnakath commented Jan 3, 2025

Hi @Andrea79 ,

thank you for the input!

To exclude a problem with compilation, I downloaded the latest (v0.19-beta2) and pushed it to the RMPP, which is running the latest firmware of RMPP (3.16.2.3).

On Safari Version 18.1.1 (20619.2.8.11.12) Running on a Mac book Air M3 2024 I get the following:

RMPP Portrait, Portrait=true

RMPP_portrait_portrait=true

RMPP Portrait, Portrait=false

RMPP_portrait

RMPP Landscape, Portrait=true

RMPP_landscape_portrait=true

RMPP Landscape, Portrait=false

RMPP_landscape

@Andrea79
Copy link

Andrea79 commented Jan 3, 2025

Hi @dnakath please try the following (which does not seem to have been covered from the trials you showed)

https://10.11.99.1:2001/?portrait=true&flip=true

It works for me when in portrait mode as you can see from the image below

remarkable

I am on a MacBook Pro M3 Max with Sonoma 14.7.1

@dnakath
Copy link
Author

dnakath commented Jan 3, 2025

Hi @Andrea79,

yes, now I got my mistake:

I wrote

https://10.11.99.1:2001/?portrait=true?flip=true

instead of your

https://10.11.99.1:2001/?portrait=true&flip=true

I can confirm, that landscape and portrait are working with the RMPP like that in my setup.

Thank you very much for your help !

@dnakath dnakath closed this as completed Jan 3, 2025
@Andrea79
Copy link

Andrea79 commented Jan 3, 2025

Hi @Andrea79,

yes, now I got my mistake:

I wrote

https://10.11.99.1:2001/?portrait=true?flip=true

instead of your

https://10.11.99.1:2001/?portrait=true&flip=true

I can confirm, that landscape and portrait are working with the RMPP like that in my setup.

Thank you very much for your help !

Sounds great! Please @dnakath could you let me know about the lag in both wifi and usb?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants