New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run() function calls newMachine() everytime #198

Open

manjunathsc24 opened this issue Jul 21, 2022 · 1 comment

manjunathsc24 commented Jul 21, 2022

in the below code of Run() , everytime it calls newmachine, is it required to be called everytime ? i guess its should work only when g.m is nil?

//if g.m == nil {
g.m = xvm.NewMachine(g.exprgraph)
defer g.m.Close()
//g.m = gorgonia.NewTapeMachine(g.exprgraph)
//}

thanks
Manjunath

Contributor

owulveryck commented Jul 21, 2022

Hello,

It’s been a while since I touched this code.
You seems to be right.
If it works for you, can you submit a PR?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment