-
-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
☂️ typescript-eslint #2180
Comments
Will type checking rules be considered for implementation at any point in time? |
Have checked
|
I looked into
|
Just comment out the tests that raise an error. |
Ref: #2180 - doc: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-function-type.md - code: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/rules/prefer-function-type.ts - test: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/tests/rules/prefer-function-type.test.ts Co-authored-by: 张润钊 <[email protected]>
) Implement @typescript-eslint/prefer-ts-expect-error Issue: #2180 Documentation: https://typescript-eslint.io/rules/prefer-ts-expect-error/ Rule source: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/rules/prefer-ts-expect-error.ts --------- Co-authored-by: Boshen <[email protected]>
Am I missing something or is the await-thenable rule missing from the list? |
It seems like we excluded all type checking rules from the recommended-type-checked list. |
@Boshen Are there plans to eventually support type checking rules? |
Related issue: #2180 original implementation - code: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/rules/prefer-literal-enum-member.ts - test: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/tests/rules/prefer-literal-enum-member.test.ts - doc: https://typescript-eslint.io/rules/prefer-literal-enum-member/
Ref: oxc-project#2180 - doc: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-function-type.md - code: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/rules/prefer-function-type.ts - test: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/tests/rules/prefer-function-type.test.ts Co-authored-by: 张润钊 <[email protected]>
…c-project#2435) Implement @typescript-eslint/prefer-ts-expect-error Issue: oxc-project#2180 Documentation: https://typescript-eslint.io/rules/prefer-ts-expect-error/ Rule source: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/rules/prefer-ts-expect-error.ts --------- Co-authored-by: Boshen <[email protected]>
partof: #2180 docs: https://typescript-eslint.io/rules/no-useless-empty-export/ code: https://github.com/typescript-eslint/typescript-eslint/blob/584db29ec44ce4e9cb71afac35d48994889168e6/packages/eslint-plugin/src/rules/no-useless-empty-export.ts test: https://github.com/typescript-eslint/typescript-eslint/blob/ac397f18176a9defd8c189b5b6b4e5d0b7582210/packages/eslint-plugin/tests/rules/no-useless-empty-export.test.ts --------- Co-authored-by: Boshen <[email protected]>
…ype (#3455) Related issue: #2180 original implementation - code: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/rules/explicit-function-return-type.ts - test: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/tests/rules/explicit-function-return-type.test.ts - doc: https://typescript-eslint.io/rules/explicit-function-return-type/ --------- Co-authored-by: Boshen <[email protected]>
Related issue: #2180 original implementation - code: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/rules/no-non-null-assertion.ts - test: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/tests/rules/no-non-null-assertion.test.ts - doc: https://typescript-eslint.io/rules/no-non-null-assertion/ typescript-eslint has a feature that is manually fixable by editor suggestions on this rule, but oxc does not have one as far as I know, so the implementation is simple compared to typescript-eslint
#3850) …sh-coalescing Related issue: #2180 original implementation - code: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/rules/no-non-null-asserted-nullish-coalescing.ts - test: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/tests/rules/no-non-null-asserted-nullish-coalescing.test.ts - doc: https://typescript-eslint.io/rules/no-non-null-asserted-nullish-coalescing/
Related issue: #2180 original implementation - code: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/rules/no-dynamic-delete.ts - test: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/tests/rules/no-dynamic-delete.test.ts - doc: https://typescript-eslint.io/rules/no-dynamic-delete/
This comment was marked as resolved.
This comment was marked as resolved.
This is the command suggested to users on our `typescript-eslint` mega-issue #2180. This should help reduce confusion.
This is the command suggested to users on our `typescript-eslint` mega-issue #2180. This should help reduce confusion.
This is the command suggested to users on our `typescript-eslint` mega-issue #2180. This should help reduce confusion.
Hi team, I ran oxlint and I caught some issues:
But, you can see all these rules have been implemented. I am using |
I did not find |
Yes, the rule |
I wonder whether it would be reasonable to introduce our own version of this which is slightly more limited. something like: https://rust-lang.github.io/api-guidelines/naming.html For typescript it would be:
and i guess we could also allow customizing these conventions. would this satisfy most of what |
|
Yes, It's satisfy most of cases. I never use type-checked with naming-convention rule. 😬 |
Warning
This comment is maintained by CI. Do not edit this comment directly.
To update comment template, see https://github.com/oxc-project/oxc/tree/main/tasks/lint_rules
This is tracking issue for
@typescript-eslint/eslint-plugin
.There are 66(+ 6 deprecated) rules.
To get started, run the following command:
Then register the rule in
crates/oxc_linter/src/rules.rs
and alsodeclare_all_lint_rules
at the bottom.Recommended rules
✨: 36, 🚫: 0 / total: 40
✨ = Implemented, 🚫 = No need to implement
Not recommended rules
✨: 12, 🚫: 0 / total: 26
✨ = Implemented, 🚫 = No need to implement
Deprecated rules
✨: 4, 🚫: 0 / total: 6
✨ = Implemented, 🚫 = No need to implement
The text was updated successfully, but these errors were encountered: