Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweet link previews not working anymore #2727

Open
robster7674 opened this issue Apr 3, 2023 · 9 comments
Open

Tweet link previews not working anymore #2727

robster7674 opened this issue Apr 3, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@robster7674
Copy link

Both in Desktop as in iOS preview links for tweets stopped working recently. I thought it was a Twitter issue at first, but for example in Telegram, for the same tweet link a preview is generated fine.

@Bilb
Copy link
Collaborator

Bilb commented Apr 6, 2023

Seems fine to me, since when did you get this issue?
Screencast from 06-04-23 16:35:57.webm

@robster7674
Copy link
Author

robster7674 commented Apr 6, 2023

@Bilb : actually, what you're showing is not a preview of the message, just for the account.

I used https://twitter.com/elonmusk/status/1643873905113722880:

Session Desktop:
image

Telegram:
image

I'm unsure when this started. I noticed it a week or two ago.

@KeeJef
Copy link
Collaborator

KeeJef commented Apr 14, 2023

Are you saying that the link preview does not appear when sent from a desktop device and received on iOS device? or that the link preview is not generated on the desktop device?

@KeeJef KeeJef added the bug Something isn't working label Apr 14, 2023
@robster7674
Copy link
Author

Both: there is no preview generated on the sending device nor is it displayed correctly on the receiving device, whether sender and receiver are Desktop or iOS or vice versa.

@robster7674
Copy link
Author

robster7674 commented Apr 25, 2023

@KeeJef : just had the same issue on Desktop with an Odysee-link: no preview generated for https://odysee.com/@drsambailey:c/Reiner-Fuellmich's-'Coronaviruses':8, while in Telegram the preview works fine.

@robster7674
Copy link
Author

I noticed in another application where I wanted to share this link that it was split at the ":" at the end, so it became:

https://odysee.com/@drsambailey:c/Reiner-Fuellmich's-'Coronaviruses'

When taking that link and putting it in Telegram I see the same general preview as I see in Session Desktop. Could it be that Session parses the link different from Telegram (and others) and splits it for whatever reason at the full colon?

@robster7674
Copy link
Author

@KeeJef previews for YouTube links on iOS and desktop also stopped working, example https://youtu.be/bRj3Sa-Q41A.

@Bilb
Copy link
Collaborator

Bilb commented May 15, 2023

When taking that link and putting it in Telegram I see the same general preview as I see in Session Desktop. Could it be that Session parses the link different from Telegram (and others) and splits it for whatever reason at the full colon?

Hey,
So about that Odysee link issue, it's actually part of the same issue I've already opened 15 months ago on the linkify-it repo at markdown-it/linkify-it#100

You can reproduce the link not being matched correctly with this page:
https://markdown-it.github.io/linkify-it/
If you paste "https://odysee.com/@drsambailey:c/Reiner-Fuellmich's-'Coronaviruses':8" on the left, you can see the last 3 char are not linkified as they are believe to not be part of the link.

Signal desktop has the same issue signalapp#6334 as they are using the same library.

@Bilb
Copy link
Collaborator

Bilb commented May 15, 2023

About the

previews for YouTube links on iOS and desktop also stopped working, example https://youtu.be/bRj3Sa-Q41A.

Do you mean that a preview send from desktop to ios does not work or desktop to desktop is broken too? I think this might be a iOS issue as they appear to be working fine desktop to desktop with that link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants