Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize SVGs for web #6

Open
RudeySH opened this issue Nov 14, 2017 · 5 comments
Open

Optimize SVGs for web #6

RudeySH opened this issue Nov 14, 2017 · 5 comments

Comments

@RudeySH
Copy link
Contributor

RudeySH commented Nov 14, 2017

SVG images should be optimized for web. I'm not use if this is already done, optimization isn't mentioned in the readme.

I don't really know anything about SVG optimization but I do know SVGO is a popular tool for doing this.

Thoughts?

@oxguy3
Copy link
Owner

oxguy3 commented Nov 14, 2017

No this isn't done currently; never got around to it. The SVGs are currently just directly how they appeared in Wikipedia (and Wikipedia editors generally oppose hosting optimized SVGs). I'll look into SVGO when I've got time today.

@RudeySH
Copy link
Contributor Author

RudeySH commented Nov 16, 2017

I could make a pull request from my fork on which I just made a commit that optimizes SVGs, however it also optimizes the flags added in #8 and #9 which have to be accepted first.

@oxguy3
Copy link
Owner

oxguy3 commented Nov 16, 2017

Sure, if you don't mind making that PR, I'd be incredibly appreciative.

@RudeySH
Copy link
Contributor Author

RudeySH commented Nov 16, 2017

Ah, I just noticed my fork still includes some flags that this repository does not have, those also have to be merged first. See #11.

@oxguy3
Copy link
Owner

oxguy3 commented Nov 16, 2017

Hey, before you bother with the SVG optimization -- I think what might be preferable is for me to setup a build script for the public version of the repository that optimizes the SVGs and also generates the PNGs. I'm figuring out my options for hosting this somewhere better than GH Pages and probably on a new domain name. (#12)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants