Skip to content

Conversation

@jesses2025smith
Copy link

No description provided.

jannes922 added a commit to jannes922/can-dbc that referenced this pull request May 26, 2025
@nyurik
Copy link
Member

nyurik commented Nov 1, 2025

I updated the code with the latest changes, but I am still a bit unclear of the usage patterns, nor are there any tests to validate it, let alone documentation

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

❌ Patch coverage is 0% with 101 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/extend/signal.rs 0.00% 91 Missing ⚠️
src/extend/mod.rs 0.00% 10 Missing ⚠️

📢 Thoughts on this report? Let us know!

@nyurik
Copy link
Member

nyurik commented Nov 10, 2025

@jesses2025smith welcome to oxibus org :) So, about this PR - please edit the PR description, explaining why we would want to add this code. Note that technically can-dbc repo is just for a structured representation of the DBC files, without the goal of de/serializing CAN data. For that, we probably want to focus on other crates -- which would target different scenarios like host vs no_std.

@jesses2025smith
Copy link
Author

I think this PR belongs to dbc-data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants