tools: upgrade oxlint and make it do more eslint stuff (#2931)

make oxlint do more of the eslint stuff

Author: david-crespo

.husky/pre-commit

@@ -1,2 +1,2 @@
 # use path directly instead of npx or npm run because it's way faster
-node_modules/.bin/oxlint --deny-warnings
+node_modules/.bin/oxlint --type-aware --deny-warnings

.oxlintrc.json

@@ -31,7 +31,29 @@
     "react-hooks/exhaustive-deps": "error",
     "react-hooks/rules-of-hooks": "error",
     "import/no-default-export": "error",
-    "consistent-type-imports": "error"
+    "consistent-type-imports": "error",
+
+    // Missing ESLint core rules
+    "eqeqeq": ["error", "always", { "null": "ignore" }],
+    "no-param-reassign": "error",
+    "no-return-assign": "error",
+    "no-restricted-imports": [
+      "error",
+      {
+        // prevent confusion due to auto-imports and barrel files
+        "paths": ["."],
+        "patterns": [
+          // import all CSS except index.css at top level through CSS @import statements
+          // to avoid bad ordering situations. See https://github.com/oxidecomputer/console/pull/2035
+          "*.css"
+        ]
+      }
+    ],
+    "radix": "error",
+
+    // TypeScript rules (currently disabled but available)
+    "@typescript-eslint/no-floating-promises": "off",
+    "@typescript-eslint/unbound-method": "off"
   },
   "overrides": [
     {

.prettierrc.js

@@ -6,6 +6,7 @@
  * Copyright Oxide Computer Company
  */
 
+// eslint-disable-next-line no-default-export
 export default {
   // note: it seems like tailwind has to be last for it to work
   plugins: ['@ianvs/prettier-plugin-sort-imports', 'prettier-plugin-tailwindcss'],

app/forms/firewall-rules-common.tsx

@@ -68,6 +68,7 @@ import { type FirewallRuleValues } from './firewall-rules-util'
 
 type TargetAndHostFilterType =
   | VpcFirewallRuleTarget['type']
+  // eslint-disable-next-line @typescript-eslint/no-duplicate-type-constituents
   | VpcFirewallRuleHostFilter['type']
 
 type TargetAndHostFormValues = {

mock-api/json-type.type-spec.ts

@@ -15,7 +15,8 @@ import type { Json } from './json-type'
 // are not equal. There's no point in wrapping this in a real test because it
 // will always pass.
 
-let val: any // eslint-disable-line @typescript-eslint/no-explicit-any
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+const val: any = undefined
 
 // just checking :)
 assertType<1>(val as 1)

package-lock.json

@@ -24,8 +24,8 @@
     "e2ec": "playwright test --project=chrome",
     "visual:baseline": "./tools/generate-visual-baseline.sh",
     "visual:compare": "./tools/compare-visual-changes.sh",
-    "lint": "oxlint && eslint --ext .js,.ts,.tsx app test mock-api",
-    "oxlint": "oxlint",
+    "lint": "oxlint --type-aware && eslint --ext .js,.ts,.tsx app test mock-api",
+    "oxlint": "oxlint --type-aware",
     "fmt": "prettier --cache --write . && npm run lint -- --fix",
     "openapi-gen-ts": "openapi-gen-ts",
     "prettier": "prettier",
@@ -114,7 +114,8 @@
     "ip-num": "^1.5.1",
     "jsdom": "^25.0.1",
     "msw": "^2.7.5",
-    "oxlint": "^1.6.0",
+    "oxlint": "^1.23.0",
+    "oxlint-tsgolint": "^0.2.0",
     "patch-package": "^8.0.0",
     "postcss": "^8.4.49",
     "postcss-import": "^16.1.0",