Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/test_repair.sh should be named tools/test_reconcile.sh #1487

Open
leftwo opened this issue Oct 2, 2024 · 1 comment
Open

tools/test_repair.sh should be named tools/test_reconcile.sh #1487

leftwo opened this issue Oct 2, 2024 · 1 comment

Comments

@leftwo
Copy link
Contributor

leftwo commented Oct 2, 2024

The test test_repair.sh has a misleading name.
It was given the "repair" name back when we still called "reconcile" "repair".
It is actually performing a reconciliation and not a live_repair.
@leftwo
Copy link
Contributor Author

leftwo commented Oct 2, 2024

The .github/buildomat/jobs/test-repair.sh also needs an update.
As well as checking whatever artifacts are created post build to be sure their names change as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leftwo