Pid to str no result #295
Open
Pid to str no result #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if `test` was defined then `no_std` was not. This makes the `std` feature weird when we run `cargo test` because the standard library is enabled while our `std` feature is not. This change makes this consistent: `cargo test` will be `no_std` while `cargo test --feature std` will not.
This ensures that all of the methods we use to create PlatformId instances check for validity. This allows us to return the string representation directly instead of through a `Result`. We still check the validity of the resultant `&str` but we now panic if it is invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this resolves #293