From 6c93f59a4e8ecb5d818a20b53fbe4730f53e366c Mon Sep 17 00:00:00 2001
From: Benjamin Naecker <ben@oxide.computer>
Date: Thu, 25 Jul 2024 16:36:57 +0000
Subject: [PATCH] Review feedback

- Addrobj name typo
- Cleanup zone setup manifest
---
 illumos-utils/src/addrobj.rs        | 2 +-
 smf/zone-network-setup/manifest.xml | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/illumos-utils/src/addrobj.rs b/illumos-utils/src/addrobj.rs
index ab14bd31fd..5a93d9a1c7 100644
--- a/illumos-utils/src/addrobj.rs
+++ b/illumos-utils/src/addrobj.rs
@@ -12,7 +12,7 @@ pub const IPV6_STATIC_ADDROBJ_NAME: &str = "omicron6";
 
 /// The name provided to all static IPv4 addresses, usually for public OPTE
 /// interfaces.
-pub const IPV4_STATIC_ADDROBJ_NAME: &str = "omicron6";
+pub const IPV4_STATIC_ADDROBJ_NAME: &str = "omicron4";
 
 /// The name provided to DHCP-configured addresses, of either family.
 pub const DHCP_ADDROBJ_NAME: &str = "omicron";
diff --git a/smf/zone-network-setup/manifest.xml b/smf/zone-network-setup/manifest.xml
index 631bc5e112..a612d5ac29 100644
--- a/smf/zone-network-setup/manifest.xml
+++ b/smf/zone-network-setup/manifest.xml
@@ -7,7 +7,7 @@
   <create_default_instance enabled='true' />
 
   <!-- Run after the zone's networking stack is up. -->
-  <dependency name='physical' grouping='require_all' restart_on='none'
+  <dependency name='network' grouping='require_all' restart_on='none'
     type='service'>
   <service_fmri value='svc:/milestone/network:default' />
   </dependency>
@@ -16,7 +16,7 @@
           have been set by the sled-agent, which happens after the
           `manifest-import` service is running.
   -->
-  <dependency name='zone-network-setup-manifest-import' type='service' grouping='require_all' restart_on='none'>
+  <dependency name='manifest-import' type='service' grouping='require_all' restart_on='none'>
     <service_fmri value='svc:/system/manifest-import:default' />
   </dependency>