Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

want time range options for omdb db migration ls #6269

Open
hawkw opened this issue Aug 8, 2024 · 0 comments
Open

want time range options for omdb db migration ls #6269

hawkw opened this issue Aug 8, 2024 · 0 comments
Assignees
Labels
Debugging For when you want better data in debugging an issue (log messages, post mortem debugging, and more) enhancement New feature or request.

Comments

@hawkw
Copy link
Member

hawkw commented Aug 8, 2024

Follow-up from #6160.

Currently, the omdb db migration list command will show the n most recent migrations matching the filter, where n is the provided --fetch-limit argument. This is fine for viewing the most recent matching migrations, but makes it hard to inspect migrations that happened in the past without listing everything. It would be nice to add the option to select a time window for listing migrations.

This all seems good as far as using the new index. Does it make sense to let the caller / CLI provide timestamps themselves? E.g., they could look at migrations in the last hour, if they wanted, or the code could use the UNIX epoch if nothing was provided.

Part of why I ask is we have given control of the limit in the CLI, but not the starting point.

Originally posted by @bnaecker in #6160 (comment)

@hawkw hawkw self-assigned this Aug 8, 2024
@hawkw hawkw added enhancement New feature or request. Debugging For when you want better data in debugging an issue (log messages, post mortem debugging, and more) labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debugging For when you want better data in debugging an issue (log messages, post mortem debugging, and more) enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

1 participant