Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ls-apis should fail when API metadata is inconsistent with Cargo package dependencies #6828

Closed
davepacheco opened this issue Oct 10, 2024 · 0 comments · Fixed by #6830
Closed

Comments

@davepacheco
Copy link
Collaborator

We're at the point where I think it's reasonable to say that if you add a new Progenitor-based client, you should also update the api-manifest.toml file. The ls-apis tool currently emits warnings when the API manifest is inconsistent with what it found in the Cargo dependency tree. These should be errors instead. This would catch cases like #6827 because they'd fail in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant