Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Press enter to open browser for auth #88

Open
david-crespo opened this issue Apr 6, 2023 · 0 comments · May be fixed by #418
Open

Press enter to open browser for auth #88

david-crespo opened this issue Apr 6, 2023 · 0 comments · May be fixed by #418
Assignees
@ahl

Comments

@david-crespo
Copy link
Contributor

Got this from the GitHub CLI, I like it. Gives a feeling of agency instead of things just happening to you.

? How would you like to authenticate GitHub CLI? Login with a web browser

! First copy your one-time code: REDA-CTED
Press Enter to open github.com in your browser...
@ahl ahl self-assigned this Apr 17, 2023
@sudomateo sudomateo linked a pull request Oct 24, 2023 that will close this issue
Open
sudomateo added a commit to sudomateo/oxidecomputer-oxide.rs that referenced this issue Dec 23, 2023
@sudomateo
auth: prompt the user to open the browser
1f08cd0 
Previously the `oxide auth login` command would automatically open the
user's browser which can be a jarring user experience.

This patch updates `oxide auth login` to prompt the user to open the
browser instead of just opening the browser automatically. Users passing
`--no-browser` will not receive this prompt and will instead have the
URL printed to standard output.

Closes: oxidecomputer#88
sudomateo added a commit to sudomateo/oxidecomputer-oxide.rs that referenced this issue Mar 26, 2024
@sudomateo
auth: prompt the user to open the browser
31d2f69 
Previously the `oxide auth login` command would automatically open the
user's browser which can be a jarring user experience.

This patch updates `oxide auth login` to prompt the user to open the
browser instead of just opening the browser automatically. Users passing
`--no-browser` will not receive this prompt and will instead have the
URL printed to standard output.

Closes: oxidecomputer#88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahl ahl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

auth: prompt the user to open the browser sudomateo/oxidecomputer-oxide.rs
2 participants
@ahl @david-crespo