Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a user agent on CLI API requests #574

Open
1 of 4 tasks
david-crespo opened this issue Feb 23, 2024 · 1 comment
Open
1 of 4 tasks

Set a user agent on CLI API requests #574

david-crespo opened this issue Feb 23, 2024 · 1 comment
Labels
feature Issue for a new feature that does not break current functionality

Comments

@david-crespo
Copy link
Contributor

Target component

  • CLI
  • SDK
  • Something else
  • Not sure

Overview

Setting a User-Agent header on API calls coming from the CLI would let us tell on the server which calls are coming from what kinds of clients for internal analysis purposes on the test racks.

Implementation details

No response

Anything else you would like to add?

No response
@david-crespo david-crespo added the feature Issue for a new feature that does not break current functionality label Feb 23, 2024
@augustuswm
Copy link
Contributor

augustuswm commented Feb 26, 2024 •
edited
Loading

I think a default user agent would make sense for the SDK as well when a caller is using Client::new. Just to throw an option out there I would suggest oxide/{version} ({api_version}). The current release being oxide/0.3.0 (0.0.6).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Issue for a new feature that does not break current functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@augustuswm @david-crespo