Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change implementation of Orientation Change call #51

Open
sheinze opened this issue Sep 3, 2019 · 0 comments
Open

Change implementation of Orientation Change call #51

sheinze opened this issue Sep 3, 2019 · 0 comments
Labels
ambient light branch These are issues concerning the ambient light branch enhancement New feature or request

Comments

@sheinze
Copy link
Member

sheinze commented Sep 3, 2019

Instead of using onClicks on the navbar, create an oberserver on the current route of the angular router & subscribe to it. Fire checkOrientation() each time, a new route drops in.

Pros: makes dom more pretty, makes app component more pretty
@sheinze sheinze added enhancement New feature or request ambient light branch These are issues concerning the ambient light branch labels Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ambient light branch These are issues concerning the ambient light branch enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sheinze