Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for bitcoin-rpc-provider #200

Open
Tibo-lg opened this issue Feb 2, 2024 · 1 comment
Open

Add test for bitcoin-rpc-provider #200

Tibo-lg opened this issue Feb 2, 2024 · 1 comment

Comments

@Tibo-lg
Copy link
Contributor

Tibo-lg commented Feb 2, 2024

Since switching to simple-wallet for the integration tests, the bitcoin-rpc-provider wallet implementation is completely untested. Possible solutions:

  • get rid of it
  • have a least one integration test using it
  • have specific tests for it (doesn't feel like worth it as it's more a helper crate)
@h10086733
Copy link

I have a question,
let label_map=self
. client
. lock()
. unwrap()
. call:<HashMap<Address, Value>>(
"Getaddressesbylabel",
&[Value:: String (keys_id. to'lower_hex_string())],

. map_err (rpc_err_to_manager_err)?; The following problem is called in the above code:
Error sending offer channel: WalletError (RpcError (JsonRpc),
I only respond normally when using the following requests:
Bitcoin cli -- regtest rpcuser=testuser - rpcpassword=lq6zequb gYTdF2_ZEutr8ywTXzLYtknzWU4nV8uVoo=- rpcwallet=Bob getaddressesbylabel "bech32"
Can you explain the reason for the problem caused by this handling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants