Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Bazel rules #498

Open
antoninbas opened this issue Nov 3, 2019 · 0 comments
Open

Cleanup Bazel rules #498

antoninbas opened this issue Nov 3, 2019 · 0 comments

Comments

@antoninbas
Copy link
Member

We tend to abuse the includes attribute of cc_library: https://docs.bazel.build/versions/master/be/c-cpp.html#cc_library.includes. Using includes impact all the dependent rules and we end up with compiler invocations with a huge number of include directives, which are hard to troubleshoot. We rely on the includes attribute because our include paths are not relative to the WORKSPACE root (https://docs.bazel.build/versions/master/bazel-and-cpp.html#include-paths), which is understandable since the project originally did not support Bazel as a build system. Since we should come up with a cleaner solution if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant