From 585f0a6a6757f3656c460009d0d2434449bf7d83 Mon Sep 17 00:00:00 2001 From: Pitchumani Sivanupandi Date: Wed, 5 Mar 2025 06:27:50 +0000 Subject: [PATCH] Updated the no start state error message to include only parser name Signed-off-by: Pitchumani Sivanupandi --- frontends/p4/validateParsedProgram.h | 2 +- testdata/p4_16_errors_outputs/accept_e.p4-stderr | 2 +- testdata/p4_16_errors_outputs/issue3338.p4-stderr | 2 +- testdata/p4_16_errors_outputs/nostart.p4-stderr | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/frontends/p4/validateParsedProgram.h b/frontends/p4/validateParsedProgram.h index 7ce4330a7b9..5a791e903ac 100644 --- a/frontends/p4/validateParsedProgram.h +++ b/frontends/p4/validateParsedProgram.h @@ -88,7 +88,7 @@ class ValidateParsedProgram final : public Inspector { void postorder(const IR::P4Parser *parser) override { auto start = parser->states.getDeclaration(IR::ParserState::start); if (!start) { - ::P4::error(ErrorType::ERR_INVALID, "Parser %1% has no 'start' state", parser); + ::P4::error(ErrorType::ERR_INVALID, "Parser %1% has no 'start' state", parser->name); } container(parser); distinctParameters(parser->getTypeParameters(), parser->getApplyParameters(), diff --git a/testdata/p4_16_errors_outputs/accept_e.p4-stderr b/testdata/p4_16_errors_outputs/accept_e.p4-stderr index e979a22d442..53f39c95b08 100644 --- a/testdata/p4_16_errors_outputs/accept_e.p4-stderr +++ b/testdata/p4_16_errors_outputs/accept_e.p4-stderr @@ -1,6 +1,6 @@ accept_e.p4(18): [--Werror=invalid] error: Invalid parser state: accept should not be implemented, it is built-in state accept { // reserved name ^^^^^^ -accept_e.p4(16): [--Werror=invalid] error: Parser parser p has no 'start' state +accept_e.p4(16): [--Werror=invalid] error: Parser p has no 'start' state parser p() ^ diff --git a/testdata/p4_16_errors_outputs/issue3338.p4-stderr b/testdata/p4_16_errors_outputs/issue3338.p4-stderr index 946b1db454f..4f9d078b9f2 100644 --- a/testdata/p4_16_errors_outputs/issue3338.p4-stderr +++ b/testdata/p4_16_errors_outputs/issue3338.p4-stderr @@ -1,3 +1,3 @@ -issue3338.p4(1): [--Werror=invalid] error: Parser parser MyParser1 has no 'start' state +issue3338.p4(1): [--Werror=invalid] error: Parser MyParser1 has no 'start' state parser MyParser1(){ ^^^^^^^^^ diff --git a/testdata/p4_16_errors_outputs/nostart.p4-stderr b/testdata/p4_16_errors_outputs/nostart.p4-stderr index e9152507877..4dd9130c0ca 100644 --- a/testdata/p4_16_errors_outputs/nostart.p4-stderr +++ b/testdata/p4_16_errors_outputs/nostart.p4-stderr @@ -1,3 +1,3 @@ -nostart.p4(17): [--Werror=invalid] error: Parser parser p has no 'start' state +nostart.p4(17): [--Werror=invalid] error: Parser p has no 'start' state parser p() { ^