Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable license regeneration for Tofino backend #5151

Open
asl opened this issue Feb 25, 2025 · 6 comments · May be fixed by #5161
Open

Disable license regeneration for Tofino backend #5151

asl opened this issue Feb 25, 2025 · 6 comments · May be fixed by #5161
Labels
infrastructure Topics related to code style and build and test infrastructure. tofino Topics related to the Tofino switch and back end.

Comments

@asl
Copy link
Contributor

asl commented Feb 25, 2025

backend/tofino/LICENSE is regenerated every time during the build. It is very easy to miss updated file when doing e.g. git commit -a and commit a license change therefore.

@asl asl added infrastructure Topics related to code style and build and test infrastructure. tofino Topics related to the Tofino switch and back end. labels Feb 25, 2025
@Vineet1101
Copy link
Contributor

@asl Taking this issue

@Vineet1101
Copy link
Contributor

@asl I want to know that when should the license file be generated or it should never be generated???

@asl
Copy link
Contributor Author

asl commented Mar 3, 2025

Well, my understanding (though I am not a lawyer) is that the license should never be generated. As otherwise any contributor could change the license of Tofino backend, which is definitely something noone should do without explicit approval from the steak-holders :)

@jafingerhut
Copy link
Contributor

I do not know the history behind this license file being generated at build time. @pkotikal @hanw Do you, perhaps?

Since the Tofino code is now released under the Apache-2.0 license, the top level LICENSE file saying that p4c is released under Apache-2.0 should cover it as well.

@Vineet1101
Copy link
Contributor

@asl so I think we should remove the command to generate the license file at build time

@asl
Copy link
Contributor Author

asl commented Mar 3, 2025

@asl so I think we should remove the command to generate the license file at build time

That's my point :)

@Vineet1101 Vineet1101 linked a pull request Mar 3, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Topics related to code style and build and test infrastructure. tofino Topics related to the Tofino switch and back end.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants