Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor internal Spectrum construction syntax #315

Open
ajjackson opened this issue Sep 19, 2024 · 1 comment
Open

Refactor internal Spectrum construction syntax #315

ajjackson opened this issue Sep 19, 2024 · 1 comment
Labels
nice to have Not urgently required, but would be an improvement

Comments

@ajjackson
Copy link
Collaborator 

          Wondering if this would be better passed as a sequence of tuples tying the data together (i.e transposed to what it is now:

_check_constructor_inputs(
    (z_data, Quantity, (-1, -1, -1), "z_data"),
    ...
)

Originally posted by @oerc0122 in #305 (comment)
@ajjackson ajjackson added the nice to have Not urgently required, but would be an improvement label Sep 19, 2024
@ajjackson
Copy link
Collaborator Author

I always find this a bit tricky to make sense of, and we now have better type-hinting and data structure tools to make this legible.

@ajjackson ajjackson mentioned this issue Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nice to have Not urgently required, but would be an improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajjackson