Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Check for unexpected Room schema diffs #1006

Open
nikclayton opened this issue Oct 15, 2024 · 0 comments
Open

ci: Check for unexpected Room schema diffs #1006

nikclayton opened this issue Oct 15, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nikclayton
Copy link
Contributor

At the moment CI can succeed, but the app can crash on startup if there was an unexpected change to a room schema in a PR.

To detect this add a new CI check.

Should probably look for two things:

  1. A PR that changes an existing schema JSON file. AIUI that shouldn't happen, any schema changes should be accompanied with a version bump and a new schema file.
  2. A PR that doesn't change the schema, but the schema is changed after the app is built. This indicates a change in one of the DAO files. Building the app then running "git diff" in the schema directories and confirming there are no diffs is probably sufficient (as any schema changes should be included as part of the PR).
@nikclayton nikclayton added enhancement New feature or request good first issue Good for newcomers labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

1 participant